Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silverstripe/FD1 #205

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Silverstripe/FD1 #205

merged 1 commit into from
Mar 10, 2025

Conversation

mcdruid
Copy link
Contributor

@mcdruid mcdruid commented Dec 4, 2024

No description provided.

@nollium nollium added the gadget chain This issue could yield a new gadget chain. label Feb 26, 2025
@nollium
Copy link
Collaborator

nollium commented Mar 10, 2025

Thank you for this contribution, I've tested the gadget chain and it works on the specified versions, I'm merging this.

@nollium nollium merged commit 508402b into ambionics:master Mar 10, 2025
@nollium
Copy link
Collaborator

nollium commented Mar 10, 2025

I've also checked the fix you proposed to the Silverstripe project.

I just wanted to warn you that the fix is partial, and this gadget chain can still be used for malicious purposes even after the fix is applied:
image

The added check only verifies that the file basename starts with a given prefix, which effectively prevents arbitrary file deletion, but, for example, path traversal and the ftp protocol is not blocked, so this gadget chain can be used for connect-backs.

UNC Paths are also usable on Windows, which makes the gadget chains usable to coerce an authentication to an attacker-controlled host, which can then be used for relay attacks.

It seems the fixes you proposed for Silverstripe/FD1, Grav/FD1, phpThumb/FD1 (and maybe others) all suffer from this same issue.

@nollium nollium mentioned this pull request Mar 10, 2025
@whattheslime whattheslime mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gadget chain This issue could yield a new gadget chain.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants